Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CMake Presets version 5 #2979

Closed
bobbrow opened this issue Jan 26, 2023 · 1 comment · Fixed by #2995
Closed

Support CMake Presets version 5 #2979

bobbrow opened this issue Jan 26, 2023 · 1 comment · Fixed by #2995
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Milestone

Comments

@bobbrow
Copy link
Member

bobbrow commented Jan 26, 2023

Brief Issue Summary

requires cmake version 3.24. It adds the following features:

https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html
testOutputTruncation

An optional string specifying the test output truncation mode. Equivalent to passing --test-output-truncation on the command line." This is allowed in preset files specifying version 5 or above.

${pathListSep}

Native character for separating lists of paths, such as : or ;.

For example, by setting PATH to /path/to/ninja/bin${pathListSep}$env{PATH}, ${pathListSep} will expand to the underlying operating system's character used for concatenation in PATH.

This is allowed in preset files specifying version 5 or above.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@bobbrow bobbrow added this to the 1.14 milestone Jan 26, 2023
@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets labels Jan 26, 2023
@nasinlock
Copy link
Contributor

I've created a pull request for the functionality changes. I will be creating a second pull request to update the tests to account for the new functionality.

@bobbrow bobbrow linked a pull request Feb 2, 2023 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants