Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper discrete progress #1961

Closed
bpasero opened this issue May 8, 2018 · 5 comments
Closed

Use proper discrete progress #1961

bpasero opened this issue May 8, 2018 · 5 comments
Assignees
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 8, 2018

Saw a progress bar today in the notification area with 5 steps to download additional things. I suggest to change this into a progress with discrete reporting (20% chunks each) to get rid of the "1/5, "2/5" etc. label which is rather ugly.

Refs: https://code.visualstudio.com/updates/v1_22#_show-long-running-operations-as-notifications-with-cancellation-support

@sean-mcmanus
Copy link
Collaborator

@WardenGnaw Did you want to fix this? The download goes away so fast for me that I barely have noticed it or had time to read what it said.

@WardenGnaw WardenGnaw self-assigned this May 15, 2018
@WardenGnaw
Copy link
Member

The 1/5 -> 2/5 files is not a direct translation of 20% progress being completed. The downloaded zip files are different sizes. For users with slower machines, they might see one file download in a minute and then another file in 50 minutes. It is frustrating to see progress bars that are near completion (e.g. 99%) and the last 1% takes a much longer time.

The reasoning behing the "1/5" indicator shows what is left and there is a label "Downloading" and "Installing" to show the phase.

@bpasero
Copy link
Member Author

bpasero commented May 15, 2018

@WardenGnaw you can still show a label that updates and discrete progress. For the label I would then maybe have a suffix (...3 more downloads to do).

@bobbrow bobbrow added the bug label May 7, 2020
@bobbrow bobbrow added this to the 0.29.0 milestone May 7, 2020
@bobbrow bobbrow modified the milestones: 0.29.0, 0.30.0 Jul 7, 2020
@elahehrashedi
Copy link
Contributor

current behaviour:

current

@elahehrashedi elahehrashedi added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 31, 2020
@sean-mcmanus
Copy link
Collaborator

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

6 participants