-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag Parser crash in get_identifier_details #3776
Comments
@lluo-rbx We need more info. The issue you originally posted to was a different repro with the same error message. It sounds like the process is crashing. Can you provide the callstack of the crashing thread from crash logs at ~/Library/Logs/DiagnosticReports? Can you try setting your C_Cpp.workspaceParsingPriority to "low" or using the C/C++: Pause Parsing command? You could also temporarily enable debug logging to see what files it's processing and potentially add those folder to files.exclude so they are not parsed. |
Yes, lots of crash logs there! here is one below; note that this is not only happening on macOS, it also happens on Ubuntu 18.04 loading the same project (same vscode / cpptools versions) - I did change the parsing priority to low a while ago (following instructions from some other posts here), and 50% of the time the CPU usage is at 25%, but when the "connection got closed" message was about to show up, I can observe that the CPU usage jump to ~80% - then right after the error message shows up (crashed), the CPU drops back to 25% (guess another process instance is spawned), but once I click open any different cpp file, it gets the same behavior again (high CPU usage, then crash/disconnect) -- if you can tell me where to grab the crash log for Ubuntu 18.04, I can paste the crash dump here again.
|
Another one:
|
More if you want:
|
Those are IntelliSense process crashes which are lower priority and don't lead to the "Connection got closed". Do you see any crash logs for "Microsoft.vscode.cpp.extension.darwin"? The "low" 25% CPU usage is only for background parsing -- if you open a file it will trigger additional parsing that will use more CPU, but for a shorter period of time. Fixing the IntelliSense process crashes usually requires an isolated repro, i.e. sample code with no |
Okay, so this is pretty consistent, all the crashes pretty much generate the same output as below: (hope this helps)
|
It looks like the crash started with 0.22.1 after we introduced IntelliSense caching for Mac. Does setting your IntelliSenseCacheSize to 0 fix the issue for you? Or does reverting back to 0.22.0 fix the issue? I've filed an internal bug on VS for the parser crash as well. If you could enable debug logging and see what file is being tag parsed in the log when it crashes and then provide some sample code that causes the crash that would help the parser team get a fix. |
Setting |
would the fix make it to the 0.24 release? |
Yeah, it's in 0.24.0-insiders2 we're working on releasing soon. |
As an aside, I see that the actual binaries are downloaded from the links as provided in the
|
The source for the binaries is closed source and not on GitHub. |
Fixed with 0.24.0-insiders2. Set the "C_Cpp.updateChannel" setting to "Insiders" to auto-install it. |
Wow, after I updated to the 0.24.0-insiders2, everything works like a charm! Excellent work! I have a feeling that vscode+cpptools is actually becoming the best C++ dev env on non-Windows platforms! |
Unfortunately, I noticed some more crashes with
|
The get_working_set_size is a known issue for a long time that is below our "crash threshold" -- let us know if you figure out a good way to repro it. The get_identifier_details crash should be fixed -- are you sure you're using the latest binaries. 0.24.0-insiders3 has fixed a bunch of other crashes. |
Hmm, 06/26 ( |
Here is a new one happening when opening the project from a new dir (like a refresh open): NOTE: this crash is very consistent, always thread 23, at exactly the same location every time! Hope this is an easy fix.
|
I moved the get_attribute_sections_details crash to a new bug at #3858 . |
Any updates on this issue? This is also happening constantly on extension version 0.23.1 with vscode version 1.35.1 - loading a fairly large C++ project causes the "connection got closed" to appear every 5 or so minutes, and before that the CPU usage of
Microsoft.VSCode.CPP.Extension.darwin
(and some other similar/related processes) is insanely high (~90% CPU usage, and the fan is spinning like crazy on my MacBook Pro 6 core i9 32G). This is definitely making VSCode for C++ dev annoying to use - I was even considering alternatives (e.g. resorting to Xcode).Please, can anyone raise the priority of this issue? It's a deal breaker!
Originally posted by @lluo-rbx in #3270 (comment)
The text was updated successfully, but these errors were encountered: