Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20: Support "concepts" syntax #4195

Closed
Zingam opened this issue Sep 5, 2019 · 11 comments
Closed

C++20: Support "concepts" syntax #4195

Zingam opened this issue Sep 5, 2019 · 11 comments
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Milestone

Comments

@Zingam
Copy link

Zingam commented Sep 5, 2019

Support the "concepts" syntax, which is not yet supported.

@michelleangela michelleangela added Language Service Visual Studio Inherited from Visual Studio labels Sep 5, 2019
@michelleangela
Copy link
Contributor

The extension's C++ standard features are inherited from Visual Studio. Please upvote this feedback ticket https://developercommunity.visualstudio.com/idea/549930/add-standard-concepts-libary-support.html on Visual Studio to support C++ 20 concepts library.

@sean-mcmanus
Copy link
Collaborator

Michelle -- that issue is for the cl.exe compiler...there might be another issue tracking IntelliSense, but we usually keep the issues open on our side until we get the fix from VS.

@sean-mcmanus sean-mcmanus reopened this Sep 5, 2019
@bobbrow bobbrow added this to the Tracking milestone Oct 10, 2019
@tloka
Copy link

tloka commented Jan 23, 2020

Any news on this?

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jan 24, 2020

C++ IntelliSense concepts support is still being worked on. I found a related VS bug at https://developercommunity.visualstudio.com/content/problem/745318/-cpp-lib-concepts-isnt-defined-in-vs-2019-1630-rel.html .

@elijaharita
Copy link

Concepts Intellisense support is now available with Visual Studio 16.6 Preview 2

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Mar 27, 2020

@elijahseedarita Yes, we plan to integrate those changes for our 1.0 release (our soon-to-be-released 0.27.0 won't have those changes yet). Also, it sounded like the support for concepts was not 100% yet.

@elijaharita
Copy link

@sean-mcmanus Thanks for all your work! =)

@sean-mcmanus sean-mcmanus modified the milestones: Tracking, 1.0.0 Apr 1, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 1, 2020
@sean-mcmanus
Copy link
Collaborator

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0-insiders2 in regards to IntelliSense parsing, but support for the global symbol (tag) parser (i.e. outline view, workspace symbol search, find all references, etc.) hasn't been checked in yet (it should be available in 0.29.0-insiders)...not sure if we need another issue to track that or if we should just keep this issue open until then.

@sean-mcmanus
Copy link
Collaborator

Actually, it looks like concepts support is still not 100% finished in Intellisense. We'll track the remaining work in #5444 .

@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@OleksandrKvl
Copy link

Not sure whether it's related to this particular issue, I have 1.45.1 VSC and 0.28.1 C++ extension and concept/requires keywords are not highlighted even though VSC clearly knows(they're suggested) that they're C++ keywords.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Projects
None yet
Development

No branches or pull requests

8 participants