Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start the language server until VSCode indicates that the file is opened in the editor #4458

Closed
bobbrow opened this issue Oct 18, 2019 · 0 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance
Milestone

Comments

@bobbrow
Copy link
Member

bobbrow commented Oct 18, 2019

VSCode sends a textDocument/didOpen message in cases besides when a document is made visible in the editor. In these cases we end up spawning an entire language server just to shut it down again. CTL+hover is one such case. VSCode does not intend to update the LSP for this, so we need to do something else.

We should consider adding logic to confirm a file is actually open in the editor before starting the language server. This can be either by checking the visibleEditors or by detecting some other LSP request.

@bobbrow bobbrow added this to the 1.0.0 milestone Oct 18, 2019
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 6, 2019
@bobbrow bobbrow closed this as completed Dec 6, 2019
@bobbrow bobbrow modified the milestones: 1.0.0, 0.26.2 Dec 6, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance
Projects
None yet
Development

No branches or pull requests

1 participant