Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some files in the database get unnecessarily removed on startup with a configuration provider #4802

Closed
sean-mcmanus opened this issue Dec 31, 2019 · 2 comments
Closed

Some files in the database get unnecessarily removed on startup with a configuration provider #4802

sean-mcmanus opened this issue Dec 31, 2019 · 2 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance
Milestone
0.26.3

Comments

@sean-mcmanus
Copy link
Collaborator

Using CMake Tools, I'm seeing around 2k files being removed (unnecessarily) from the database on startup and then reparsed. Reproed with 0.26.2 and 0.26.3-insiders2. Might be a regression.
@Colengms
Copy link
Collaborator

Colengms commented Jan 6, 2020

This is because we haven't heard from the custom configuration provider yet. Other issues related to this scenario that resulted in incorrectly configured TU's have been addressed be ensuring the TU is corrected when the new configuration arrives. The next step is to give the provider some time to start up before falling back to the cpptools configuration.

@Colengms Colengms mentioned this issue Jan 8, 2020
Merged
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 9, 2020
@bobbrow bobbrow modified the milestones: 1.0.0, 0.26.3 Jan 9, 2020
@sean-mcmanus
Copy link
Collaborator Author

@Colengms I still see this reproing with 0.26.3-insiders3 and our latest code -- from the logging it looks like the correct browse.path is getting used, but the parse_root is operating on a copy of old data.

@Colengms Colengms mentioned this issue Jan 14, 2020
Merged
@sean-mcmanus sean-mcmanus mentioned this issue Jan 16, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance
Projects
None yet
Milestone
0.26.3
Development

No branches or pull requests
3 participants
@bobbrow @sean-mcmanus @Colengms