Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize some phrases/words in autocomplete info #5370

Closed
michelleangela opened this issue Apr 27, 2020 · 2 comments
Closed

Localize some phrases/words in autocomplete info #5370

michelleangela opened this issue Apr 27, 2020 · 2 comments
Assignees
@Colengms
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone
0.29.0

Comments

@michelleangela
Copy link
Contributor

Localize following words/phrases:

  • "preprocessor keyword"
    image

  • "overloads"
    image

  • "specialization"
@michelleangela michelleangela added Language Service world ready An issue relating string character encodings, localization translations, etc. labels Apr 27, 2020
@michelleangela michelleangela added this to the 0.28.0 milestone Apr 27, 2020
@Colengms
Copy link
Contributor

Colengms commented Apr 27, 2020 •
edited
Loading

Since these aren't log messages, we're either going to need a new request/response so the native code can ask the TypeScript side to provide a localized string, or we'll need to reroute completion through the equivalent TypeScript provider class to allow the TypeScript side an opportunity to do localized string replacement before returning the results.

@michelleangela michelleangela modified the milestones: 0.28.0, 0.29.0 Apr 27, 2020
@Colengms
Copy link
Contributor

Since it's going to require the same solution, merging this issue with #5340.

@Colengms Colengms mentioned this issue Apr 28, 2020
Closed
@Colengms Colengms self-assigned this Apr 28, 2020
@Colengms Colengms mentioned this issue Jun 17, 2020
Merged
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 17, 2020
@michelleangela michelleangela mentioned this issue Sep 15, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
None yet
Milestone
0.29.0
Development

No branches or pull requests
3 participants
@sean-mcmanus @michelleangela @Colengms