Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Comments are not permitted in JSON" appears when c_cpp_properties.json is open but hasn't been made active yet #6132

Closed
sean-mcmanus opened this issue Sep 13, 2020 · 3 comments
Closed

"Comments are not permitted in JSON" appears when c_cpp_properties.json is open but hasn't been made active yet #6132

sean-mcmanus opened this issue Sep 13, 2020 · 3 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone
1.1.0

Comments

@sean-mcmanus
Copy link
Collaborator

It goes away after the c_cpp_properties.json is made active. Not sure if there's a way to call setTextDocumentLanguage on the files open in the workspace beforehand.
@sean-mcmanus sean-mcmanus added bug Language Service help wanted Can be fixed in the public (open source) repo. labels Sep 13, 2020
@sean-mcmanus
Copy link
Collaborator Author

vscode.workspace.textDocuments doesn't contain first that haven't been activated yet.

@sean-mcmanus
Copy link
Collaborator Author

There's a thread at microsoft/vscode#15178

@sean-mcmanus
Copy link
Collaborator Author

Oh...we can just check if the file exists, even if it's not open.

@sean-mcmanus sean-mcmanus added quick fix and removed help wanted Can be fixed in the public (open source) repo. labels Sep 13, 2020
@sean-mcmanus sean-mcmanus added this to the 1.1.0 milestone Sep 13, 2020
@sean-mcmanus sean-mcmanus mentioned this issue Sep 13, 2020
Merged
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 22, 2020
@sean-mcmanus sean-mcmanus removed their assignment Sep 25, 2020
@Colengms Colengms closed this as completed Nov 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@bobbrow @sean-mcmanus @Colengms