MSVC compile_commands.json - Intellisense not handling -external:I includes

[paul-reilly]

Issue Type: Bug

If our compile_commands.json contains -experimental:external and include paths such as -external:IC:/myincludepath, Intellisense does not appear to handle these paths, resulting in a case of the dreaded squiggles with files #included from these locations.

Extension version: 1.1.1
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.19041

[sean-mcmanus]

I see it described at https://devblogs.microsoft.com/cppblog/broken-warnings-theory/ , but not in the current docs (https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-alphabetically?view=msvc-160).

[paul-reilly]

Yes, it does seem as though it has been stuck in experimental limbo for 3 years.

[sean-mcmanus]

cl /? Gives “/external:I - location of external headers”, so it looks like it got promoted out of experimental (i.e. /experimental:external doesn’t appear to be needed anymore). The missing docs might be a "bug", not sure yet.

[paul-reilly]

Oh yeah I see that it's in cl help. I just checked and it seems that it still can't be used without /experimental::

cl : Command line warning D9007 : '/external:I' requires '/experimental:external or /external:W'; option ignored

[sean-mcmanus]

Yeah, you're right (I was mistaken).

[github-actions]

This feature request is being closed due to insufficient upvotes. When enough upvotes are received, this issue will be eligible for our backlog.

[sean-mcmanus]

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.4.0-insiders

[paul-reilly]

Thanks @sean-mcmanus!