Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__builtin_coro_* methods aren't recognized by IntelliSense in gcc mode with -fcoroutines arg #6575

Closed
sean-mcmanus opened this issue Nov 24, 2020 · 1 comment
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Nov 24, 2020

Repro is with 1.2.0-insiders:

{
    "configurations": [
        {
            "name": "Linux",
            "includePath": [
                "${workspaceFolder}/**"
            ],
            "intelliSenseMode": "gcc-x64",
            "cppStandard": "c++20",
            "compilerPath": "/usr/bin/g++-10",
            "compilerArgs": ["-fcoroutines"]
        }
    ],
    "version": 4
}
    struct foo
    {
      bool done() const noexcept { return __builtin_coro_done(_M_fr_ptr); }
      void resume() const { __builtin_coro_resume(_M_fr_ptr); }
      void destroy() const { __builtin_coro_destroy(_M_fr_ptr); }
    protected:
      void* _M_fr_ptr;
  };

Bug: IntelliSense doesn't recognize the __builtin_coro_* methods. It works with clang mode (which doesn't need the -fcoroutines arg). The case is valid with g++ 10 or newer.

@sean-mcmanus sean-mcmanus added bug Language Service Works in VS So we'd need to fix it for VS Code to reach parity. labels Nov 24, 2020
@sean-mcmanus sean-mcmanus added this to the 1.2.0 milestone Nov 24, 2020
@sean-mcmanus sean-mcmanus self-assigned this Nov 24, 2020
@sean-mcmanus sean-mcmanus removed this from the 1.2.0 milestone Nov 24, 2020
@sean-mcmanus sean-mcmanus removed their assignment Nov 24, 2020
@sean-mcmanus sean-mcmanus added Visual Studio Inherited from Visual Studio and removed Works in VS So we'd need to fix it for VS Code to reach parity. labels Nov 25, 2020
@sean-mcmanus sean-mcmanus added this to the Tracking milestone Nov 25, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 17, 2020
@sean-mcmanus sean-mcmanus modified the milestones: Tracking, 1.2.0 Dec 17, 2020
@sean-mcmanus
Copy link
Collaborator Author

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Projects
None yet
Development

No branches or pull requests

1 participant