Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2.0-insiders regression: "Go To Symbol in Workspace" is not working anymore #6793

Closed
sean-mcmanus opened this issue Jan 15, 2021 · 5 comments · Fixed by #6795
Closed

1.2.0-insiders regression: "Go To Symbol in Workspace" is not working anymore #6793

sean-mcmanus opened this issue Jan 15, 2021 · 5 comments · Fixed by #6795
Labels
bug Feature: Symbol Search fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. quick fix regression A bug that didn't exist in a previous release
Milestone
1.2.0

Comments

@sean-mcmanus
Copy link
Contributor

Hello I see now that limit was increased, but the (Ctrl+T) Go To Symbols Workspace is not working anymore. Is there a connection with this fix?

Originally posted by @jenuc78 in #6766 (comment)
@sean-mcmanus sean-mcmanus self-assigned this Jan 15, 2021
@sean-mcmanus sean-mcmanus added bug Feature: Symbol Search insiders Currently only repros with our latest Insiders release. regression A bug that didn't exist in a previous release labels Jan 15, 2021
@sean-mcmanus sean-mcmanus added this to the 1.2.0 milestone Jan 15, 2021
@sean-mcmanus sean-mcmanus mentioned this issue Jan 15, 2021
Closed
@sean-mcmanus
Copy link
Contributor Author

@jenuc78 cpptools and TypeScript are returning the symbols to VS Code, but for some reason VS Code isn't showing them. It could be a VS Code bug. Still investigating...

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 15, 2021
@sean-mcmanus sean-mcmanus mentioned this issue Jan 15, 2021
Merged
@sean-mcmanus
Copy link
Contributor Author

It was a TypeScript regression -- unfortunately, the TypeScript system doesn't do a good enough job warning when a "string" type doesn't match a "vscode.Uri" type. Fix at #6795

@sean-mcmanus sean-mcmanus removed their assignment Jan 15, 2021
@sean-mcmanus sean-mcmanus changed the title 1.2.0-insiders regression: Go To Symbols Workspace is not working anymore 1.2.0-insiders regression: "Go To Symbol in Workspace" is not working anymore Jan 15, 2021
@jenuc78
Copy link

jenuc78 commented Jan 18, 2021

Hello, how to get this fix? I have version 1.2.0-insiders but does not seems to work, the same version was also before reporting the issue.

@sean-mcmanus sean-mcmanus mentioned this issue Jan 20, 2021
Closed
@sean-mcmanus
Copy link
Contributor Author

The fix is in 1.2.0-insiders2, which should be released later today.

@jenuc78
Copy link

jenuc78 commented Jan 21, 2021

Thank you, it works now

@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Symbol Search fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. quick fix regression A bug that didn't exist in a previous release
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix Go to Symbol in Workspace microsoft/vscode-cpptools
2 participants
@sean-mcmanus @jenuc78