Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make punctuation marks in description of property and configuration settings consistent #6870

Closed
michelleangela opened this issue Jan 29, 2021 · 2 comments
Assignees
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@michelleangela
Copy link
Contributor

Some property descriptions have periods at the end and some don't. Example:

With "." period
image

Without "." period
image

Some property descriptions use double quotes, and some use single quotes. Example:

This uses single quotes:
image

This uses double quotes:
image

@michelleangela michelleangela added Language Service Feature: Configuration An issue related to configuring the extension or IntelliSense labels Jan 29, 2021
@michelleangela michelleangela added this to the 1.3.0 milestone Jan 29, 2021
@sean-mcmanus
Copy link
Collaborator

I think it should be normalized to end with periods and use double quotes.

@bobbrow bobbrow added the bug label Mar 30, 2021
@bobbrow bobbrow modified the milestones: 1.3.0, 1.4.0 Apr 6, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.4.0, 1.5.0 May 28, 2021
@sean-mcmanus sean-mcmanus self-assigned this Jun 30, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.5.0, 1.5.0-insiders3 Jun 30, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.5.0-insiders3, 1.6.0 Jun 30, 2021
@sean-mcmanus
Copy link
Collaborator

I was going to do this for 1.5.0, but I think it'll break too many translations before we want to ship.

@sean-mcmanus sean-mcmanus removed their assignment Jul 9, 2021
@sean-mcmanus sean-mcmanus self-assigned this Jul 30, 2021
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 30, 2021
@sean-mcmanus sean-mcmanus removed this from the 1.6.0 milestone Aug 17, 2021
@sean-mcmanus sean-mcmanus added this to the 1.7.0 milestone Aug 17, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.7.0, 1.7.0-insiders Sep 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

3 participants