Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No completion results are shown in macro definitions #9078

Closed
sean-mcmanus opened this issue Mar 23, 2022 · 2 comments
Closed

No completion results are shown in macro definitions #9078

sean-mcmanus opened this issue Mar 23, 2022 · 2 comments
Assignees
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

@sean-mcmanus Thanks for your consideration.
I think it is the same bug.
simple macro definitions will not have any autocomplete while writing them

#define INVERTER_BASE        (0x80)
#define HAL_RX               (0x01+INVERTER_BASE)  // INVERTER_BASE will not be autocompleted even if declared as a variable

function renaming

#include "task.h"
#define os_add_task   xTaskCreate //same issue

I meant by "pages of macro constants" the register map file for microcontroller registers. ex: CMSIS.
when making modifications or making your own it is very important to have IntelliSense.

many thanks

Originally posted by @AshrafMasoud5 in #5616 (comment)

@sean-mcmanus
Copy link
Collaborator Author

This is similar to #4662 , except we were using that issue to track completion in the name part of the macro and not the value/definition (not sure yet if they're the same case).

@sean-mcmanus sean-mcmanus self-assigned this Mar 23, 2022
@sean-mcmanus sean-mcmanus added this to the 1.10.0 milestone Mar 23, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 29, 2022
@sean-mcmanus
Copy link
Collaborator Author

@AshrafMasoud5 This should be fixed with 1.10.2 (pre-release).

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

1 participant