Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code analysis "Disable all" option doesn't automatically clear all the warnings that are disabled #9364

Closed
sean-mcmanus opened this issue May 25, 2022 · 2 comments · Fixed by #9495
Closed

Code analysis "Disable all" option doesn't automatically clear all the warnings that are disabled #9364

sean-mcmanus opened this issue May 25, 2022 · 2 comments · Fixed by #9495
Assignees
@sean-mcmanus
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service
Milestone
1.11.1

Comments

@sean-mcmanus
Copy link
Collaborator

I see it only clear the 1 diagnostic on which it is invoked. I thought this had been implemented/tested already -- I think the fix should be pretty quick/easy.
@sean-mcmanus sean-mcmanus added bug Language Service insiders Currently only repros with our latest Insiders release. Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. labels May 25, 2022
@sean-mcmanus sean-mcmanus added this to the 1.10 milestone May 25, 2022
@sean-mcmanus sean-mcmanus self-assigned this May 25, 2022
@sean-mcmanus sean-mcmanus changed the title clang-tidy "Disable all" option doesn't automatically clear all the warnings that are disabled Code analysis "Disable all" option doesn't automatically clear all the warnings that are disabled May 25, 2022
@sean-mcmanus
Copy link
Collaborator Author

I don't repro the bug now -- if anyone finds repro steps, let me know. I'm guessing the bug still exists, but only in some special case.

@sean-mcmanus sean-mcmanus closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@sean-mcmanus sean-mcmanus added the not reproing We're not able to reproduce the issue (it's unlikely to get fixed until we find one). label Jun 7, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.10, 1.11 Jun 7, 2022
@sean-mcmanus sean-mcmanus removed the not reproing We're not able to reproduce the issue (it's unlikely to get fixed until we find one). label Jun 8, 2022
@sean-mcmanus
Copy link
Collaborator Author

I'm reproing this now with 1.10.5 with

int main()
{
    int i;
    return i;
}

and

    "C_Cpp.codeAnalysis.clangTidy.checks.enabled": [
        "*"
    ]

after disabling "clang-analyzer-core.uninitialized.UndefReturn".

@sean-mcmanus sean-mcmanus reopened this Jun 8, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.11, 1.11.0 Jun 8, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.11.0, 1.11.1 Jun 16, 2022
@sean-mcmanus sean-mcmanus mentioned this issue Jun 23, 2022
Merged
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service
Projects
None yet
Milestone
1.11.1
Development

Successfully merging a pull request may close this issue.

Fix remove code analysis diagnostics for the disable case. microsoft/vscode-cpptools
1 participant
@sean-mcmanus