From 8a011968ba4e8cfe6ebde5256c318dbae6a29061 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Tue, 13 Oct 2020 12:56:13 -0700 Subject: [PATCH 1/2] Fix 'Build and Debug Active File' race condition with EngineLogs If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and `${fileBasenameNoExtension}` will resolve to something similar to `./extension-output-#5`. This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario. --- Extension/src/Debugger/configurationProvider.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/Extension/src/Debugger/configurationProvider.ts b/Extension/src/Debugger/configurationProvider.ts index 9df035bc15..0c7eb9b8ce 100644 --- a/Extension/src/Debugger/configurationProvider.ts +++ b/Extension/src/Debugger/configurationProvider.ts @@ -274,7 +274,6 @@ class CppConfigurationProvider implements vscode.DebugConfigurationProvider { const outputChannel: logger.Logger = logger.getOutputChannelLogger(); outputChannel.appendLine(localize("debugger.launchConfig", "Launch configuration:")); outputChannel.appendLine(JSON.stringify(config, undefined, 2)); - logger.showOutputChannel(); } return config; From 1d7e3f7c8962b7edc3b44b5b67434a506a172d1f Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Tue, 13 Oct 2020 13:10:37 -0700 Subject: [PATCH 2/2] Update configurationProvider.ts --- Extension/src/Debugger/configurationProvider.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Extension/src/Debugger/configurationProvider.ts b/Extension/src/Debugger/configurationProvider.ts index 0c7eb9b8ce..1757cb6ec1 100644 --- a/Extension/src/Debugger/configurationProvider.ts +++ b/Extension/src/Debugger/configurationProvider.ts @@ -274,6 +274,8 @@ class CppConfigurationProvider implements vscode.DebugConfigurationProvider { const outputChannel: logger.Logger = logger.getOutputChannelLogger(); outputChannel.appendLine(localize("debugger.launchConfig", "Launch configuration:")); outputChannel.appendLine(JSON.stringify(config, undefined, 2)); + // TODO: Enable when https://github.com/microsoft/vscode/issues/108619 is resolved. + // logger.showOutputChannel(); } return config;