Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure links are distinguished from surrounding text in a way that does not rely on color (a[href$="license"]) #7368

Closed
Govardhani-T opened this issue Jun 11, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@Govardhani-T
Copy link

"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver".

GitHub Tags:

#A11yTCS; #A11ySev2; #A11yMAS; #DesktopWeb; #Chrome; #WCAG1.4.1; #WCP; #Use of Color; #Visual Studio Code Services; #A11yAuto; #AI4W; #BM_VisualStudioCodeServices_Web_Apr2023; #Win11;#clink-in-text-block;

Environment Details: 

Application Name:  code.visualstudio.com
URL: https://code.visualstudio.com/download?dark-plus-v2
Microsoft Edge version 125.0.0.0 (Official Build) (64-bit)

Repro Steps:

  1. Hit the URL: https://code.visualstudio.com/download?dark-plus-v2
  2. Run fast pass and observe the issue.

Issue:

Ensure links are distinguished from surrounding text in a way that does not rely on color (link-in-text-block - https://dequeuniversity.com/rules/axe/4.8/link-in-text-block?application=msftAI)

Target application:

Download Visual Studio Code - Mac, Linux, Windows - https://code.visualstudio.com/download?dark-plus-v2

Element path:

a[href$="license"]

Snippet:

license terms

How to fix:

Fix any of the following:
The link has insufficient color contrast of 1.02:1 with the surrounding text. (Minimum contrast is 3:1, link text: #4daafc, surrounding text: #9ba3b4)
The link has no styling (such as underline) to distinguish it from the surrounding text

Environment: Microsoft Edge version 125.0.0.0

====

This accessibility issue was found using Accessibility Insights for Web 2.42.0 (axe-core 4.8.4), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Attachment:

image

@rzhao271 rzhao271 self-assigned this Jul 16, 2024
@rzhao271 rzhao271 added this to the July 2024 milestone Jul 16, 2024
@rzhao271
Copy link
Contributor

There are underlines now, and the issue should be fixed.

@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jul 16, 2024
@meganrogge
Copy link
Contributor

@Govardhani-T could you please retest and close this issue if all works well?

@Govardhani-T
Copy link
Author

Verified the issue in the environment. Issue is fixed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants