C# DevKit suggests refactorings that break build/don't compile

[solrevdev]

Type: Bug

C# Dev Kit suggests refactoring's that break the build/does not compile after you agree to and make the suggested changes.

This was the original issue

This seemed to go away with the latest C# Extension update but has returned today.

I checked to see if It did the same against an old public repo https://github.com/solrevdev/blazor-on-vercel and it does so you can use that to hopefully recreate. This public repo is what I am logging this bug against now.

Screenshots

The other ticket #289 @jasonmalinowski asked for some extra logging info which I've done via dotnet dump:

https://www.dropbox.com/scl/fo/35p9psbe8oouxh1tiw7s8/h?rlkey=l2j7eyxfkwmafdy9bclce8qjg&dl=0

@timheuer I'll tag you as well although not sure if you need to see the output.

I've included the commands I use to generate in case I'm doing it wrong in a readme.md. The file is massive so I do suspect I'm not doing it right.

If you need any more information please just let me know.

Extension version: 0.2.100
VS Code version: Code - Insiders 1.81.0-insider (4dfb92c1736a68cbede67a373f6050594836f2fb, 2023-07-31T22:45:12.709Z)
OS version: Darwin arm64 22.5.0
Modes:

System Info

Item	Value
CPUs	Apple M1 (8 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	3, 3, 5
Memory (System)	16.00GB (0.04GB free)
Process Argv	--crash-reporter-id 4833a52a-ed11-4d5d-b549-6ace2400b2b2
Screen Reader	no
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
vsc_aa:30263845
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
7ij38806:30687742
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30771523
showindicator:30766888
pythongtdpath:30726887
i26e3531:30792625
gsofa:30797620
welcomedialog:30800244
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
copilotsettingc:30767685
e537b577:30772214
h0f32768:30792099
asynctokenver:30799129
dsvsc013:30777762
dsvsc014:30777825
diffeditorv1:30786205

[timheuer]

Thanks. I'm certainly not seeing that in my environment, but I don't have a mac. Will have to defer to @jasonmalinowski on some things he's looking in to as well.

For reference, the only ones suggested to remove for me in Roslyn (versus you are getting ALL of them suggested to remove)

[arunchndr]

@jasonmalinowski sending to you purely for mac availability. Please feel free to move to roslyn if we have the needed info to continue the convo in our repo.

[jasonmalinowski]

@arkalyanms Oh no problem, I thought this was already assigned to me actually!

[github-actions]

This issue has been marked as stale after 14 days of inactivity.@[@jasonmalinowski@], could you please take a look?