gorename: can't find package containing... when using modules

[bitfield]

Steps to Reproduce:

1. In this repo: https://github.com/bitfield/uptimerobot
2. Open main.go, select the main identifier, and 'Rename symbol' to anything.
3. Error message in output:

Rename failed: gorename: can't find package containing /Users/john/git/bitfield/uptimerobot/main.go 

GOPATH is not set and there is a valid go.mod file in the module root.

go version go1.11.1 darwin/amd64
vscode-go 0.6.94-beta4
Code 1.28.2

[lanrat]

I'm having the same issue, unfortunately it appears that the gorename tool does not yet support go modules.

More info: #1954 (comment)

[bitfield]

I thought @ramya-rao-a had already forked gorename to add module support... or was that wishful thinking on my part?

[ramya-rao-a]

gorename doesn't yet support modules.

See Go modules support in Visual Studio Code

[rohmanhm]

Using with Find All References it works fine. I thought it was a bug. But after browsing gorename it turns out that it doesn't support go modules yet.

If you still curious, You can track current status about gorename, here's the links:

• x/tools/cmd/gorename: doesn't work outside $GOPATH golang/go#27571
• cmd/go: track tools/tooling updates to support modules golang/go#24661

[lanrat]

Slight update in the Go Modules in 2019 blog post today. It looks like the new golang.org/x/tools/go/packages package will be the place where this, and other IDE integrations will implemented with support for modules.

[shaodahong]

@ramya-rao-a go module in vscode now supported, please review this issue

[douglarek]

gopls has supported go rename(golang/go#27571 (comment)), and vscode-go has supported it too.

Please update your gopls codes and only use this settings:

 "go.useLanguageServer": true,

[ramya-rao-a]

Thanks for the update @douglarek and @shaodahong

@douglarek The value for the setting go.languageServerExperimentalFeatures that you have shared is the default value, so one doesn't need to specify the same in settings again. Would you mind updating your instructions?

The only 2 things to ensure are

• Have the setting "go.useLanguageServer": true
• Get the latest version gopls

[shaodahong]

ok, found need update gopls version