Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Explore ways to sync the right version of the go-langserver #828

Closed
ramya-rao-a opened this issue Mar 1, 2017 · 2 comments
Closed

Explore ways to sync the right version of the go-langserver #828

ramya-rao-a opened this issue Mar 1, 2017 · 2 comments
Assignees

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 1, 2017

See #706 (comment)

Or gopkg.in

@ramya-rao-a ramya-rao-a self-assigned this Mar 1, 2017
@ramya-rao-a ramya-rao-a changed the title Explore post-install step to install the right version of the go-langserver Explore ways to sync the right version of the go-langserver Mar 5, 2017
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Mar 23, 2017

  • Updating language server as part of post-install of the extension:

We support the language server binary being in user's GOPATH (which can be different from the default or the one set as env var), PATH or a whole another location (using go.toolsGopath).

Therefore, adding a post install step (which wouldnt be aware of user settings) for syncing the language server is a non-started

  • Language server uses tagging and the extension uses gopkg.in to get the minimun supported version

Only catch is that after a couple of major versions, user's workspace can get crowded with all the multiple versions of golanguage server

@ramya-rao-a
Copy link
Contributor Author

In the next update of the Go extension, the user will be prompted when we attempt to use features from the language server that are not yet supported in the version that the user has.

We do this by looking at the capabilities returned by the server.

This should be more than enough to let the user know to update their version of the language server.

Experimental features can be controlled by the go.languageServerExperimentalFeatures setting and using the middleware to not use the results from the language server if needed.

Therefore, closing this issue.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant