Feature: golang: package qualified symbols

[josh-tepper]

Issue copied from here: microsoft/vscode#23509

When doing a "global symbol search" ('# ' in the palette), I wish that it was possible to qualify the symbol name with the package name. E.g., for a symbol Sym in package my/package/here, I would like to be able to type both of:

• my/package/here.Sym
• here.Sym

[josh-tepper]

@ramya-rao-a

[ramya-rao-a]

I dont know how I lost this issue in my notifications for over a year! Apologies.

Yes, this is do-able.

We currently use the go-symbols tool to look for the given query in the symbol search.
What we can do is

• If the search term has a /, then provide all packages as result
• If the search term has a ., assume the preceding text is the package name, then pass the package path to go-symbols to restrict the search to just that package.

PRs are most welcome.

• https://github.com/Microsoft/vscode-go/blob/master/src/goSymbol.ts is the file to make changes in
• https://github.com/Microsoft/vscode-go/wiki/Building,-Debugging-and-Sideloading-the-extension-in-Visual-Studio-Code has instructions on how to get started

[josh-tepper]

Oh -- cool. I won't have a chance to open up a PR this week, and then I'll be traveling for two weeks. Will take a look at opening a PR when I get back

[ramya-rao-a]

@stamblerre This is related to the workspace symbol search feature.
Any thoughts on how you would tackle the above via the language server?

[stamblerre]

@ramya-rao-a: Just to confirm, you are referring to the Workspace Symbols feature of the LSP (https://microsoft.github.io/language-server-protocol/specification#workspace_symbol)? I filed golang/go#33844 to track this.

[ramya-rao-a]

@stamblerre Yes, that's the one

@josh-tepper Now that there is active development on an official language server for Go via gopls, this issue is being closed in favor of having the features requested here via the language server.

For more on language server integration with this extension, please see Go language server

To go a feature request for gopls, use the Go issue tracker