Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for debugging webviews in UWPs #1209

Closed
connor4312 opened this issue Feb 22, 2022 · 1 comment · Fixed by #1282
Closed

Support for debugging webviews in UWPs #1209

connor4312 opened this issue Feb 22, 2022 · 1 comment · Fixed by #1282
Assignees
@connor4312
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2022

Comments

@connor4312
Copy link
Member

Today js-debug can debug webview2's embedded in C++, but @DavidShoe requested we also add support for webviews in UWPs.

This is a little more involved, and he created a sample repo that demonstrates this. Primarily, acquiring the pipe involves some low level win32 calls. Therefore I've wrapped this in a native Node module in https://github.com/microsoft/vscode-win32-app-container-tokens, and will integrate it from there into js-debug.
@connor4312 connor4312 added the feature-request Request for new features or functionality label Feb 22, 2022
@connor4312 connor4312 added this to the March 2022 milestone Feb 22, 2022
@connor4312 connor4312 self-assigned this Feb 22, 2022
@egamma egamma mentioned this issue Feb 22, 2022
Closed
81 tasks
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@connor4312 connor4312 modified the milestones: March 2022, April 2022 Mar 23, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@connor4312 connor4312 modified the milestones: April 2022, May 2022 Apr 29, 2022
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@connor4312 connor4312 mentioned this issue May 20, 2022
Merged
@connor4312
Copy link
Member Author

Marking verified from @DavidShoe's report

@connor4312 connor4312 added verified Verification succeeded verification-needed Verification of issue is requested labels Jun 1, 2022
@aliscco aliscco mentioned this issue Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

feat: support UWP webview debugging microsoft/vscode-js-debug
1 participant
@connor4312