Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Window settings are hard to identify #12393

Closed
amunger opened this issue Dec 12, 2022 · 3 comments · Fixed by #12810
Closed

Interactive Window settings are hard to identify #12393

amunger opened this issue Dec 12, 2022 · 3 comments · Fixed by #12810
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Dec 12, 2022

All Jupyter extension settings are under the same group, but it's hard to tell what would apply to IW vs notebooks in general

@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label Dec 12, 2022
@amunger amunger self-assigned this Dec 12, 2022
@amunger amunger added the interactive-window Impacts interactive window label Dec 12, 2022
@amunger amunger added this to the February 2023 milestone Feb 22, 2023
@amunger
Copy link
Contributor Author

amunger commented Feb 22, 2023

verification steps:

  1. open vscode without activating the jupyter extension (no .ipynb or .py editors visible)
  2. open your settings JSON and add some deprecated settings (should have deprecation message)
"jupyter.interactiveWindowMode": "perFile",
"jupyter.newCellOnRunLast": false,
"jupyter.sendSelectionToInteractiveWindow": true,
"jupyter.enableAutoMoveToNextCell": false
  1. activate the jupyter extension (open a .ipynb file)
  2. check that the settings are eventually migrated

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 23, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 23, 2023

Doesn't work in a non-default profile. When I switch to a non-default profile and then run the "Open Current Profile Settings (JSON)" command, that opens a settings file that isn't the same as the JSON file used for the default profile.

Edit: doesn't seem to work on the default profile either.

Jupyter version v2023.2.1000551017
Python version v2023.2.1000551017

@rzhao271 rzhao271 reopened this Feb 23, 2023
@rzhao271 rzhao271 added verification-found Issue verification failed verified Verification succeeded and removed verified Verification succeeded verification-found Issue verification failed labels Feb 23, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 23, 2023

And it's good now, at least on the default profile.
Edit: good on a non-default profile as well.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants