Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Notebook Editor, Interactive Window, Python Editor does not work with diff #1270

Closed
harvastum opened this issue Jun 8, 2020 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@harvastum
Copy link

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

  1. Select two .ipynb files from explorer
  2. Right click, select "Compare Selected" from context menu

Actual behavior

Two diff panels open up for a split second, then close.

Expected behavior

The diff panels show up and allow user to inspect files.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: N/A
  • Extension version: 2020.5.80290
  • VS Code version: 1.45.1
  • Setting python.jediEnabled: true
  • Setting python.languageServer: Jedi | Microsoft | None
  • Python and/or Anaconda version: 3.6.1 (but it's irrelevant)
  • OS: Windows 10
  • Virtual environment: N/A

Developer Tools Console Output

None

@harvastum
Copy link
Author

Looks very similar to this: https://github.com/microsoft/vscode-python/issues/7905#issue-505479525
but it's triggered differently.

@we-taper
Copy link

we-taper commented Jun 8, 2020

In my case, the automatically loaded Notebook Editor always mess up with diffs inside the Source Control panel. And setting "python.dataScience.useNotebookEditor": false works as a temporary solution.

@joyceerhl
Copy link
Contributor

joyceerhl commented Jun 8, 2020

@harvastum Repro-ed. We'll triage this, thank you for the bug report!

Note also that we did not regress microsoft/vscode-python#7905—opening the diff panels from source control still works fine. We may be able to address this by returning early in onDidChangeActiveTextEditorHandler as was done in microsoft/vscode-python#8081

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug temp-nice-for-october labels Nov 13, 2020
@greazer greazer added the P2 label Nov 14, 2020
@greazer
Copy link
Member

greazer commented Jun 6, 2021

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.

@greazer greazer closed this as completed Jun 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

6 participants