Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qsl Widget does not render #12885

Closed
DonJayamanne opened this issue Feb 21, 2023 · 8 comments
Closed

qsl Widget does not render #12885

DonJayamanne opened this issue Feb 21, 2023 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Originally filed by matthai here #12843 (comment)

I have the same problem. My setup is perhaps even simpler.

I am running a fresh install of code-insider locally on an ubuntu 20.04 machine. I am trying to run the qsl package from pip (pip install qsl in a fresh env) via the 3 lines of code below, which works on the web-based jupyter. My project has only one root.

On the web-based jupyter client, this works fine.

On vscode with ipywidgets 8.0.4 and pre-release versions of jupyter and python extensions, I get:

sshot

The contents of the error are very similar to that of @christasich:

[Open Browser Console for more detailed log - Double click to close this message]
Failed to load model class 'MediaLabelerModel' from module 'qslwidgets'
Error: No version of module qslwidgets is registered
at ph.loadClass (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4099813)
at ph.loadClass (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4403287)
at ph.loadModelClass (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4097773)
at ph._make_model (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4094616)
at ph.new_model (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4092246)
at ph.handle_comm_open (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4091039)
at https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-renderers-1.0.15/out/node_modules/%40vscode/jupyter-ipywidgets8/dist/ipywidgets.js:2:4402511
at g._handleCommOpen (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-2023.2.1000521025/out/webviews/webview-side/ipywidgetsKernel/ipywidgetsKernel.js:2:36493)
at async g._handleMessage (https://file+.vscode-resource.vscode-cdn.net/home/matthai/.vscode-insiders/extensions/ms-toolsai.jupyter-2023.2.1000521025/out/webviews/webview-side/ipywidgetsKernel/ipywidgetsKernel.js:2:38387)

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Feb 21, 2023
@DonJayamanne DonJayamanne self-assigned this Feb 21, 2023
@DonJayamanne DonJayamanne added the ipywidgets Rendering, loading, saving, anything to do with IPyWidgets label Feb 21, 2023
@DonJayamanne DonJayamanne changed the title qsl Widget not rendering qsl Widget does not render Feb 21, 2023
@DonJayamanne
Copy link
Contributor Author

This works for me,

Screenshot 2023-02-21 at 13 54 55

@matthai please could you enable logging as follows:

  • Open settings & go into Jupyter->Logging
  • Change the value to verbose
  • Reload VS Code,
  • Attempt to repro the issue & then copy the output from the Jupyter output panel.

@DonJayamanne DonJayamanne added the info-needed Issue requires more information from poster label Feb 21, 2023
@matthai
Copy link

matthai commented Feb 21, 2023

@DonJayamanne great to see it can work!

I switched Jupyter->Logging to verbose, restarted vs code and re-ran the code.

I get exactly the same result (attached). Is the "Jupyter output panel" you mention just the area below the cell?

qslout2
jupsetting

@DonJayamanne
Copy link
Contributor Author

Attempt to repro the issue & then copy the output from the Jupyter output panel.

You can get the output from here

  • Open the command palette
  • Select the command Jupyter: Show Output
  • Ensure you copy all of the contents, and please do this after you have replicated the issue

Also note:

  • Please open your developer tools via the command Toggle Developer tools
  • Ensure you have the network tab open
  • Then open the notebook and replicate the issue
    There might be some network issues logged in here and I'd be interested in seeing them
    If there are any, then please capture a screenshot of those network errors

@matthai
Copy link

matthai commented Feb 21, 2023

Here you go
network
jupout.txt

@matthai
Copy link

matthai commented Feb 21, 2023

@DonJayamanne , note that the output of jupyter is in the file jupout.txt at the bottom of my previous post. It's a bit hard to notice.

@DonJayamanne
Copy link
Contributor Author

ms-toolsai-jupyter-insiders.vsix.zip

This issue was just identified in another place and i have a fix for this
You can verify the fix by installing the above VSIX

  • Download the file
  • Extract it
  • Install it in VS Code using the command Install from VSIX
  • Reload VS Code Insiders and test again

That should fix it, if not, please comment here #12843

Closing as a duplicate of #12843

@matthai
Copy link

matthai commented Feb 21, 2023

Hallelujah, @DonJayamanne that worked. Thanks!

@DonJayamanne
Copy link
Contributor Author

Thank you for your patience and feedback, this fix will be in the next insiders (hence the next relase as well)

@DonJayamanne DonJayamanne added the verified Verification succeeded label Feb 21, 2023
@DonJayamanne DonJayamanne added this to the February 2023 milestone Feb 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants