Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid kernel selection for IW with remote kernels #13505

Closed
DonJayamanne opened this issue May 16, 2023 · 1 comment
Closed

Invalid kernel selection for IW with remote kernels #13505

DonJayamanne opened this issue May 16, 2023 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link
Contributor

  • Start IW
  • Select a remote kernel spec and run a cell
  • Go into kernel picker and select the active kernel session that points to this IW
  • Things hang
    I think whats going on is, with IW kernel sessions are never persisted (unlike notebooks)
    However the controller that points to the kernel session is selected
    So the session is killed while also being used from another controller

Need to properly dispose the controller as soon as the other session is shutdown.
Ugly scenario

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label May 16, 2023
@DonJayamanne DonJayamanne self-assigned this May 16, 2023
@DonJayamanne
Copy link
Contributor Author

The cause is

  • For IW, when starting remote kernels, we will shut those remote kernel sessions
  • Thus when switching kernels, the previous kernel is shutdown and then we attempt to connect to the live kernel
  • However the live kernel no longer exists, as the previous kernel ws the same as the live kerfnel, and the previous/live kernel was shutdown

This only applies to IW, as we always shtudown remote kernels started by us
With notebooks we never shut them down.

One way of address this is to simply have one controller for remote kernels.
I.e. fix #9865

        // If this Interactive Window, then always shutdown sessions (even with remote Jupyter).
        if (this.resource && getResourceType(this.resource) === 'interactive') {
            return true;
        }

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

1 participant