Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift+enter no longer runs a cell after pressing esc multiple times #14474

Closed
PierXuY opened this issue Oct 9, 2023 · 3 comments · Fixed by microsoft/vscode#195271
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@PierXuY
Copy link

PierXuY commented Oct 9, 2023

Thank you very much for such an excellent product! The overall experience with vscode jupyter is great.
But at the same time, there are a few things that I think can improve the experience:

  • It is hoped that the same variables can be highlighted across cells.Currently, only the same variable in the same cell can be highlighted.
  • When the Ese key is pressed to focus on the cell container, if the Ese key is pressed again or multiple times, the cell cannot be run using the shortcut keys Ctrl + Enter or Shift + Enter. This has some impact on the experience. Is it possible to automatically focus when using Ctrl + Enter or Shift + Enter, so that the current cell can execute normally and avoid inadvertent failure?

Looking forward to a more perfect experience, thank you!

@PierXuY PierXuY added the feature-request Request for new features or functionality label Oct 9, 2023
@amunger
Copy link
Contributor

amunger commented Oct 9, 2023

The first point should be covered by microsoft/vscode#184259

For the second, that sounds like a bug, but I'm not able to repro - after pressing escape multiple times, I can still run the cell with shift/ctrl+enter. Does the cell still appear focused? Are you on the latest version of vs code?

@amunger amunger added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Oct 9, 2023
@amunger amunger changed the title Cross-cell highlighting and execute shortcut key optimization. shift+enter no longer runs a cell after pressing esc multiple times Oct 9, 2023
@amunger amunger removed the info-needed Issue requires more information from poster label Oct 9, 2023
@amunger
Copy link
Contributor

amunger commented Oct 9, 2023

never mind, I can hit it now.

@PierXuY
Copy link
Author

PierXuY commented Oct 10, 2023

never mind, I can hit it now.

Thanks for the reply. I'm using the latest version of vscode.

After pressing escape multiple times, the cell still appears focused, but when I press shift/ctrl+enter, the cell does not execute normally. In addition, when I press shift+enter, the next cell will be focused but the previous cell is not executed.

I wonder if other users have similar situations.

@alexdima alexdima added this to the October 2023 milestone Oct 26, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants