Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline diffview for latest item is incorrect due to sorting of properties in metadata #15402

Closed
Tracked by #205637
DonJayamanne opened this issue Mar 19, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug on-testplan
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

There are no differences in the timeline (this is the very last entry in timeline)
However diffs are displayed due to the order of properties in metadata differing

Screenshot 2024-03-20 at 07 48 25

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 19, 2024
@DonJayamanne
Copy link
Contributor Author

Its a problem with JS stringify, the order of property is preserved (ie. the order in which they have been added)

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 19, 2024

Do we need an API in ipynb extension to add/update metadata to get around this?
Or just write custom code in each ext.

Note: Serializer ext needs to ensure properties are always sorted
Problem with 3rd party exts that update these objects

@DonJayamanne
Copy link
Contributor Author

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants