Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep viewpoint (don't scroll) when Shift+Enter is pressed #5186

Closed
Tracked by #7360
CavalloneChen opened this issue Mar 17, 2021 · 4 comments
Closed
Tracked by #7360

Keep viewpoint (don't scroll) when Shift+Enter is pressed #5186

CavalloneChen opened this issue Mar 17, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior papercut 🩸 Something affecting the productivity of the team
Milestone

Comments

@CavalloneChen
Copy link

CavalloneChen commented Mar 17, 2021

In jupyter-lab, this is the default behavior.
When long cell output is generated, current behavior leads to a big jump of the viewpoint. And I often found myself in a situation where I have to scroll to find my current location.

@CavalloneChen CavalloneChen changed the title Automatically clear cell outputs when Shift+Enter is pressed Keep viewpoint when Shift+Enter is pressed Mar 17, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Mar 17, 2021

Thanks for the suggestion.

We should probably push this to VS code itself as they're taking ownership of the UI an scrolling.

@greazer greazer changed the title Keep viewpoint when Shift+Enter is pressed Keep viewpoint (don't scroll) when Shift+Enter is pressed Mar 22, 2021
@greazer greazer added the papercut 🩸 Something affecting the productivity of the team label Mar 22, 2021
@greazer greazer added the notebook-workflow Issues that interrupt expected or desirable behavior label Aug 5, 2021
@greazer greazer mentioned this issue Aug 31, 2021
5 tasks
@greazer
Copy link
Member

greazer commented Sep 1, 2021

Current behavior of extension (insiders) seems identical now to Jupyter classic scrolls when shift-enter is pressed. However, there is still a difference in behavior that I think could account for what @CavalloneChen is describing.

In this gif, notice that Jupyter classic prioritizes on keeping the user looking at the same location in the notebook. VS Code is optimizing for seeing the latest output.
ScrollBehavior

This almost feels like it could be a setting as either behavior is reasonable.

@benlindsay
Copy link

This almost feels like it could be a setting as either behavior is reasonable.

Agreed that this could be a setting. I think defaulting to the behavior seen in Jupyter Lab would be best though, meaning prioritizing not scrolling

@amunger
Copy link
Contributor

amunger commented Sep 19, 2023

adding this as part of microsoft/vscode#191086, we'll track it through there.

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior papercut 🩸 Something affecting the productivity of the team
Projects
None yet
Development

No branches or pull requests

6 participants