Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + Enter Shortcut should execute cell or render markdown even if in edit mode #6037

Closed
claudiaregio opened this issue May 29, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@claudiaregio
Copy link
Contributor

claudiaregio commented May 29, 2021

There is still an influx of customer feedback where the Shift + Enter shortcut key is not behaving as expecting in our notebooks.
I believe this is due to the fact that core contributes multiple shift + enters, and their notebook one is being trumped by the other condition. Let's contribute Shift + Enter as well so it overrides and we make sure it works for our users.

**Edit: Let's make sure this applies to Ctrl + Enter as well

@claudiaregio claudiaregio added the bug Issue identified by VS Code Team member as probable bug label May 29, 2021
@greazer greazer changed the title Native Notebooks - Shift + Enter Shortcut Shift + Enter Shortcut should execute cell or render markdown even if in edit mode Jun 3, 2021
@joyceerhl joyceerhl self-assigned this Jun 8, 2021
@joyceerhl
Copy link
Contributor

Markdown cells aren't rendered for ctrl+enter when in edit mode either.

@claudiaregio
Copy link
Contributor Author

Let's make sure that behavior persists for ctrl + enter too

@IanMatthewHuff
Copy link
Member

Validated. Shift+Enter / Ctrl+Enter work in edit and command mode. I can look at the Ctrl+Enter => control mode when it merges.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants