Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorators to current line for run by line #6210

Closed
Tracked by #5607
rchiodo opened this issue Jun 8, 2021 · 4 comments
Closed
Tracked by #5607

Add decorators to current line for run by line #6210

rchiodo opened this issue Jun 8, 2021 · 4 comments
Assignees
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 8, 2021

Should be able to:

  • Add line color
  • Add glyph in the margin (need icon? hopefully can use codicons)

See:
https://code.visualstudio.com/api/references/vscode-api#DecorationRenderOptions

@greazer greazer added this to the July 2021 Release milestone Jun 8, 2021
@DavidKutu DavidKutu self-assigned this Jul 16, 2021
@DavidKutu
Copy link

I think this is done
image

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 16, 2021

I assume Rob is handling the IP indicator? We used to hack that in before, but since VS code knows about the debugging it will show the ip indicator?

Actually if that's the case, maybe you didn't need to do anything here? Cause VS code would be putting the decorator too.

@DavidKutu
Copy link

what's the IP indicator?

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 16, 2021

The little arrow that shows what line you're currently running.

IP stands for instruction pointer. In C++ land it's called that and there's a register on the CPU that usually stores the address of the IP called rip

https://en.wikipedia.org/wiki/Program_counter

@greazer greazer modified the milestones: July 2021, August 2021 Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants