Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jupyter -> Send Selection to Interactive Window, true by default (iff Python stops auto-installing the Jupyter extension). #6565

Closed
joyceerhl opened this issue Jul 7, 2021 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window upstream-python Blocked on upstream Python Ext

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jul 7, 2021

This prompt is used to configure whether shift+enter sends selections in Python files to the terminal or interactive window. Looks like it's been removed entirely (no references in either Python or Jupyter extension).

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug regression labels Jul 7, 2021
@joyceerhl
Copy link
Contributor Author

This hurts new interactive window users the most because shift+enter will go to the terminal instead of the interactive window

@joyceerhl joyceerhl added the interactive-window Impacts interactive window label Jul 7, 2021
@greazer greazer added this to the August 2021 Release milestone Jul 8, 2021
@greazer greazer added important Issue identified as high-priority and removed important Issue identified as high-priority labels Jul 30, 2021
@joyceerhl joyceerhl modified the milestones: August 2021, September 2021 Aug 24, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 20, 2021
@greazer greazer modified the milestones: October 2021, On Deck Oct 8, 2021
@greazer greazer self-assigned this Oct 25, 2021
@greazer
Copy link
Member

greazer commented Nov 15, 2021

This functionality was removed when the Jupyter functionality was moved out of the Python extension and into it's own. This was the commit id: 8f50e87.

Rather than re-add the prompt, we can consider making the jupyter -> Send Selection to Interactive Window true by default, if and when the Python extension removes installing Jupyter by default.

@greazer greazer changed the title jupyter.ownsSelection prompt missing Make Jupyter -> Send Selection to Interactive Window, true by default (iff Python stops auto-installing the Jupyter extension). Nov 15, 2021
@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Jan 24, 2022

Blocked on microsoft/vscode-python#18073

@rchiodo rchiodo added the upstream-python Blocked on upstream Python Ext label Jan 24, 2022
@rchiodo rchiodo modified the milestones: January 2022, February 2022 Jan 24, 2022
@luabud
Copy link
Member

luabud commented Jan 25, 2022

is the idea here that if users clicked "shift+enter" we'd prompt them to install the Jupyter extension?

@rchiodo
Copy link
Contributor

rchiodo commented Jan 25, 2022

No actually when/if the python extension removes the jupyter extension as an optional dependency, we're going to switch this setting to true:

"jupyter.sendSelectionToInteractiveWindow": false

@luabud
Copy link
Member

luabud commented Jan 25, 2022

got it, thanks for the clarification!

@rebornix
Copy link
Member

It seems we didn't switch jupyter.sendSelectionToInteractiveWindow to true yet and we might want to reconsider.

@amunger
Copy link
Contributor

amunger commented Aug 15, 2022

We shouldn't override that functionality as long as Python still depends on this extension: microsoft/vscode-python#18073

@amunger
Copy link
Contributor

amunger commented Dec 7, 2022

I think the current functionality is good - if the file has a # %% cell in it, it will be sent to the IW, we can add a launch configuration as well to make run in IW more discoverable

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window upstream-python Blocked on upstream Python Ext
Projects
None yet
Development

No branches or pull requests

7 participants