Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBL ends up displaying unnecessary messages when prompted to install/upgrade ipykernel #7779

Closed
Tracked by #5607
DonJayamanne opened this issue Oct 1, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release notebook-run-by-line

Comments

@DonJayamanne
Copy link
Contributor

  • Ensure you have ipykernel 5 or you have a notebook with a selected kernel that doesnt' have ipykernel installed
  • Now try RBL
  • You'll end up with the message Install, Change Kernel, Cancel
  • When selecting Change Kernel/Cancel I still get the message ipykernel setup required for this feature (now I need to click cancel twice)
  • Also Clicking install and then cancelling the installationn will also throw the same message ipykernel setup required for this feature all over again.
  • Clicking cancel should not display any message, it should just exit from the entire workflow.

install

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug notebook-run-by-line labels Oct 1, 2021
@DonJayamanne DonJayamanne changed the title Installing ipykernel for RBL ends up displaying unnecessary messages RBL ends up displaying unnecessary messages when prompted to install/upgrade ipykernel Oct 1, 2021
@rchiodo rchiodo added this to the October 2021 milestone Oct 4, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 4, 2021

Change kernel and cancel are not working correctly.

@DonJayamanne DonJayamanne added the candidate Issue identified as probable candidate for fixing in the next release label Oct 7, 2021
@DonJayamanne DonJayamanne added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release labels Oct 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release notebook-run-by-line
Projects
None yet
Development

No branches or pull requests

5 participants