Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When executing multiple cells queued ones don't show up anymore #8022

Closed
ghost opened this issue Aug 6, 2021 · 10 comments · Fixed by #8642
Closed

When executing multiple cells queued ones don't show up anymore #8022

ghost opened this issue Aug 6, 2021 · 10 comments · Fixed by #8642
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Aug 6, 2021

Issue Type: Bug

When executing multiple cells queued ones don't show up anymore; it only shows the most recent one being currently executed and not the ones that are queued for execution in Interactive Python.

VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:14:40.191Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 8.00GB (0.15GB free)
Process Argv --crash-reporter-id d07ed298-647e-451d-99de-de1722f8bc11
Screen Reader no
VM 0%
Extensions (33)
Extension Author (truncated) Version
codesnap adp 1.3.4
Bookmarks ale 13.1.0
python-inline-query-highlighting ard 1.0.2
path-intellisense chr 2.4.0
vscode-sql-beautify cla 0.2.5
gitignore cod 0.7.0
bracket-pair-colorizer-2 Coe 0.2.1
githistory don 0.6.18
gitlens eam 11.6.0
autoconf mae 0.1.0
markdown-converter man 3.1.2
git-graph mhu 1.30.0
python ms- 2021.8.1102490946
vscode-pylance ms- 2021.8.0
jupyter ms- 2021.8.1195043623
remote-containers ms- 0.191.0
remote-ssh ms- 0.65.7
remote-ssh-edit ms- 0.65.7
remote-wsl ms- 0.58.2
vscode-remote-extensionpack ms- 0.21.0
azure-account ms- 0.9.8
cmake-tools ms- 1.7.3
autodocstring njp 0.5.4
material-icon-theme PKi 4.9.0
kuskus-kusto-language-server ros 1.0.1
kuskus-kusto-syntax-highlighting ros 1.1.8
markdown-preview-enhanced shd 0.5.22
rewrap stk 1.14.0
code-spell-checker str 1.10.2
cmake twx 0.0.17
vscodeintellicode Vis 1.2.14
clang-format xav 1.9.0
vscode-scope yiw 0.0.24

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30322571
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwt:30329788
pythonvssor306:30344512
bridge0708:30335490
vstre464:30346472

@vscodebot
Copy link

vscodebot bot commented Aug 6, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@greazer
Copy link
Member

greazer commented Aug 10, 2021

When pressing shift+enter in a py file with cells, in the old webview users were able to queue up a set of cells to run. Each would appear in the IW with the spinning * until they were executed.

The native view does not work this way, right now.

@ardeego, if this is blocking your workflow, you can temporarily opt out of the new experience by setting:

    "jupyter.enableNativeInteractiveWindow":false

@rebornix
Copy link
Member

rebornix commented Aug 22, 2021

@joyceerhl can you help take a look? Unassinging my self as I'm out.

@rebornix rebornix removed their assignment Aug 22, 2021
@joyceerhl
Copy link
Contributor

Added this to the issue tracking polishing the IW.

@rchiodo rchiodo assigned rebornix and unassigned joyceerhl Oct 14, 2021
@rebornix rebornix transferred this issue from microsoft/vscode Oct 25, 2021
@rebornix rebornix removed their assignment Oct 25, 2021
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window labels Oct 25, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

@rebornix wouldn't this be handled in core?

@rebornix rebornix added this to the October 2021 milestone Oct 25, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

Looks like it just adds them but they never execute:

image

@DonJayamanne
Copy link
Contributor

Looks like a golden scenario, hence adding to triage

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

No actually those two cells executed too fast.

It only adds one cell at a time if you try to execute a queue. So you can't tell what's in the queue anymore.

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

You can see the reason this is happening here:

const notebookCell = await this.addNotebookCell(notebookEditor.document, code, fileUri, line, id);

We create an execution promise for all the cells queued up. The addition of the cell to the notebook is also part of this promise so the cells don't get added until they are about to be executed.

@greazer
Copy link
Member

greazer commented Dec 1, 2021

In playing around with during my thanksgiving personal projects, I ran into this problem and it hurt the experience more than I had originally realized. Oftentimes when writing a real notebook, you're going to be running cells that take a bit to run. While they are running you may be perusing your file for other changes to make. You're not just sitting there waiting for them to run. When this happens you can easily lose your place. "What cell did I last run?" "Ok, I see this output from one of the cells... did I run this one yet?" etc. Therefore, this is not just a regression, I'm marking it as iw-golden.

@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@rchiodo rchiodo self-assigned this Jan 5, 2022
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants