Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel selector should be auto displayed after specifying local or remote Jupyter server for connections #8795

Closed
joyceerhl opened this issue Jan 25, 2022 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-remote Applies to remote Jupyter Servers verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jan 25, 2022

Testing #8778

I found the flow to add a remote kernel somewhat unintuitive. The user has to do the following:

  1. Execute the 'Specify local or remote Jupyter server for connections' command and paste in the server url. At this point they are still connected to the local kernel in the kernel selector
  2. Go back into the kernel selector and pick which kernel from the remote connection they want to use

After step 1 I was surprised that no kernel was autoselected and my previous, local kernel connection remained the same, and I needed to go into a different UI entrypoint to select the kernel. I suppose we can't autoselect a kernel from the remote connection because there could be multiple kernels running on the remote server? If that's the case, could we nudge users to pick the kernel by immediately invoking notebook.selectKernel with no arguments to put up the kernel selector?

@DonJayamanne
Copy link
Contributor

If i don't have a notebook open I cannot display kernel picker (what do we do with the selection), possible the user wants to use IW and not notebooks.
I don't think we can display a kernel picker at all as we do'nt know whether they want to change kernels for existing NB or not.
Its possible this extra prompt would be annoying to users.

  • To discuss in standup,
  • perhaps leave this open to see if users report similar issues (confusion about not getting prompted or the like).
  • The kernel picker UX that Miguel designed with remote servers would address this workflow (the kernel picker has the ability to define the servers & the like)

@DonJayamanne DonJayamanne removed their assignment Jan 26, 2022
@greazer greazer added discuss-at-standup notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-remote Applies to remote Jupyter Servers and removed needs-triage labels Jan 27, 2022
@greazer
Copy link
Member

greazer commented Jan 27, 2022

Consider moving to suggested kernel picker that Miguel had spec'd out some time ago. This will address this problem in a smoother way.

@greazer greazer added feature-request Request for new features or functionality and removed enhancement labels May 4, 2022
@IanMatthewHuff IanMatthewHuff self-assigned this Aug 12, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@DonJayamanne DonJayamanne self-assigned this Nov 14, 2022
@DonJayamanne DonJayamanne added this to the November 2022 milestone Nov 14, 2022
@DonJayamanne
Copy link
Contributor

this will be fixed with the new kernel picker ui

@DonJayamanne DonJayamanne added the verification-needed Verification of issue is requested label Nov 30, 2022
@rebornix rebornix closed this as completed Dec 1, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 1, 2022

After specifying to use the remote server, the kernel picker is not automatically displayed.
However, I do immediately see the remote option when opening the kernel picker afterwards. Is this enough for verification?

@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Dec 1, 2022
@rebornix rebornix added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Dec 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-remote Applies to remote Jupyter Servers verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants