Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt for prerelease in a dev container #9005

Closed
kieferrm opened this issue Feb 11, 2022 · 3 comments
Closed

Don't prompt for prerelease in a dev container #9005

kieferrm opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started

Comments

@kieferrm
Copy link
Member

  1. start up vscode insiders with the remote containers extension installed
  2. open https://github.com/Chuxel/notebooks-test in a dev container
  3. Open the notebook file

-> I get prompted with the following notification:

image

We should not prompt in a dev container. Also, the usage of "recommended" seems to suggest that if I don't follow the recommendation that I might not have as great of an experience as if I don't follow the recommendation. This is not the case though. Whether or not I use the prerelease version of an extension is a personal choice.

@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Feb 11, 2022
@greazer greazer added the info-needed Issue requires more information from poster label Feb 14, 2022
@greazer
Copy link
Member

greazer commented Feb 14, 2022

@kieferrm, why do you think that we should not prompt in this case?

@kieferrm
Copy link
Member Author

Yes, I propose to not prompt. My reasoning:

  1. I assume that when you open a dev container with Insiders, you are not a new Insiders users. I believe this is a safe assumption since most people either user Insiders or Stable and usually stick with their choice.
  2. If you use Jupyter notebooks regularly and because of 1) you have seen the prompt before.
  3. Because of 1) and 2) if you see the prompt, it's either because you either installed the extension while being in the dev container or the dev container spec said the extension should be installed.
  4. If you installed the extension while being in the dev container, you made your choice at the moment of installation that you don't want to use the prerelease version.
  5. If the devcontainer spec says you need the extension and because of 2) you are new to the Jupyter extension you are not the right audience for the prerelease version of the extension.

@IanMatthewHuff
Copy link
Member

Resolving as a duplicate based on my fix for #11477 (which was totally removing the pre-release notification).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started
Projects
None yet
Development

No branches or pull requests

4 participants