Dont set PYTHONNOUSERSITE unless explicitly asked #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
May 25, 2022
| @@ -39,7 +39,7 @@ export class JupyterInterpreterStateStore { | |||
| } | |||
| const memento = this.memento.get<string | undefined>(key, undefined); | |||
| if (memento) { | |||
| return Uri.file(memento); | |||
| return Uri.parse(memento); | |||
There was a problem hiding this comment.
This was causing problems with setting the jupyter interpreter. Caused by the string to URI change.
There was a problem hiding this comment.
Really sucks because if we fail to get this, we clear it. So a lot of people might have had their interpreter cleared we set a long time ago.
rchiodo
commented
May 25, 2022
| "jupyter.excludeUserSitePackages": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Add PYTHONNOUSERSITE to kernels before starting. This prevents global/user site-packages from being used in the PYTHONPATH of the kernel.", |
There was a problem hiding this comment.
Added this is an option in case we break anybody. We can have them set this to try the old way. Telemetry should tell us how many people have this set.
DonJayamanne
approved these changes
May 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #10124 +/- ##
=====================================
Coverage 55% 55%
=====================================
Files 203 203
Lines 9243 9244 +1
Branches 1492 1492
=====================================
+ Hits 5092 5093 +1
Misses 3747 3747
Partials 404 404
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9995
Tested this with