Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Notebook preload scripts in renderer ext #11672

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Ship Notebook preload scripts in renderer ext #11672

merged 1 commit into from
Oct 17, 2022

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Oct 16, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #11672 (7954fec) into main (298dcee) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11672   +/-   ##
======================================
  Coverage     62%      62%           
======================================
  Files        483      483           
  Lines      34337    34335    -2     
  Branches    5564     5564           
======================================
+ Hits       21561    21562    +1     
+ Misses     10716    10712    -4     
- Partials    2060     2061    +1     
Impacted Files Coverage Δ
.../notebooks/controllers/vscodeNotebookController.ts 82% <ø> (-1%) ⬇️
src/kernels/execution/notebookUpdater.ts 88% <0%> (-8%) ⬇️
src/kernels/helpers.ts 67% <0%> (-2%) ⬇️
src/platform/msrCrypto/msrCrypto.js 19% <0%> (-1%) ⬇️
src/kernels/common/baseJupyterSession.ts 80% <0%> (+<1%) ⬆️
src/notebooks/controllers/kernelRanking/helpers.ts 60% <0%> (+<1%) ⬆️
src/kernels/jupyter/jupyterKernelService.node.ts 74% <0%> (+1%) ⬆️
src/kernels/jupyter/baseKernelConnectionWrapper.ts 37% <0%> (+2%) ⬆️
...rc/notebooks/controllers/controllerRegistration.ts 87% <0%> (+2%) ⬆️
src/platform/common/cancellation.ts 66% <0%> (+3%) ⬆️

@DonJayamanne DonJayamanne merged commit 1b7f10d into main Oct 17, 2022
@DonJayamanne DonJayamanne deleted the issue6404 branch October 17, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship require.js and jquery in Renderer extension
3 participants