Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runStartupCommand instead of runMagicCommand #8486

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

DonJayamanne
Copy link
Contributor

For #8485

@DonJayamanne DonJayamanne requested a review from a team as a code owner December 8, 2021 17:27
@@ -0,0 +1 @@
Remove `jupyter.runMagicCommands` (which has been deprecared for over a year) in favor of `runStartupCommands`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove it from the package.json? I thought VS code did that with deprecated stuff eventually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never existed in the package.json, hence the PR, it hasn't been there for a long time.

@codecov-commenter
Copy link

Codecov Report

Merging #8486 (b5bc2ce) into main (74ca817) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #8486   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        377     377           
  Lines      23913   23912    -1     
  Branches    3679    3677    -2     
=====================================
+ Hits       17200   17201    +1     
+ Misses      5253    5214   -39     
- Partials    1460    1497   +37     
Impacted Files Coverage Δ
src/client/common/configSettings.ts 86% <ø> (-1%) ⬇️
src/client/common/types.ts 100% <ø> (ø)
src/client/datascience/jupyter/kernels/kernel.ts 76% <100%> (ø)
...ence/notebook/intellisense/intellisenseProvider.ts 83% <100%> (ø)
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 77% <0%> (-1%) ⬇️
src/client/api/pythonApi.ts 64% <0%> (ø)
src/client/common/configuration/service.ts 82% <0%> (ø)
src/client/datascience/jupyter/jupyterUtils.ts 65% <0%> (ø)
src/client/datascience/jupyter/jupyterSession.ts 72% <0%> (ø)
... and 10 more

@DonJayamanne DonJayamanne merged commit e7381f4 into main Dec 8, 2021
@DonJayamanne DonJayamanne deleted the issue8485 branch December 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants