Display local & remote kernels together #8490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8490 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 377 377
Lines 23928 23951 +23
Branches 3679 3686 +7
=====================================
+ Hits 17189 17226 +37
+ Misses 5246 5235 -11
+ Partials 1493 1490 -3
|
DonJayamanne
force-pushed
the
localAndRemove
branch
from
de8b2c4 to
2fa9f8b
Compare
DonJayamanne
commented
Dec 9, 2021
| @@ -106,6 +117,19 @@ export class MultiStepInput<S> implements IMultiStepInput<S> { | |||
| input.placeholder = placeholder; | |||
| input.ignoreFocusOut = true; | |||
| input.items = items; | |||
| if (onDidChangeItems) { | |||
There was a problem hiding this comment.
As per demo, allow one to remove individual items
DonJayamanne
commented
Dec 9, 2021
DonJayamanne
commented
Dec 9, 2021
| : DataScience.jupyterSelectURIQuickPickTitleRemoteOnly(), | ||
| onDidTriggerItemButton: (e) => { | ||
| const url = e.item.url; | ||
| if (url && e.button.tooltip === DataScience.removeRemoteJupyterServerEntryInQuickPick()) { |
There was a problem hiding this comment.
Abiliy to remove an item instead of clearing everything in the list.
rchiodo
reviewed
Dec 9, 2021
rchiodo
approved these changes
Dec 9, 2021
IanMatthewHuff
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8489
Need to add some tests