Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save profile with connection string + Enable Trust Server Certificate #17805

Closed
cheenamalhotra opened this issue Sep 15, 2023 · 0 comments · Fixed by #17806
Closed

Comments

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Sep 15, 2023

  • MSSQL Extension Version: main
  • VS Code Version: Latest
  • OS Version: Windows 11

Steps to reproduce:

  1. Create a new connection with connection string (that triggers Enable Trust Server Certificate error)
  2. Click on Enable Trust Server Certificate

Below error is captured in Extension Host and OE tree fails to load:

stack trace: TypeError: Cannot read properties of undefined (reading 'length')
    at getConnectionDisplayString (c:\Users\cmalhotra\Code\GitHub\vscode-mssql\src\models\connectionInfo.ts:150:11)
    at Object.getPicklistDescription (c:\Users\cmalhotra\Code\GitHub\vscode-mssql\src\models\connectionInfo.ts:114:25)
    at ConnectionStore.createQuickPickItem (c:\Users\cmalhotra\Code\GitHub\vscode-mssql\src\models\connectionStore.ts:389:26)
    at c:\Users\cmalhotra\Code\GitHub\vscode-mssql\src\models\connectionStore.ts:469:36

Issue occurs as conn string is not updated properly, and profile is saved also by itself - in connection string format.

Mitigation:
Use Connection properties instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant