Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Regression when bundling this library #44

Closed
AviVahl opened this issue Aug 9, 2022 · 2 comments · Fixed by #46
Closed

Regression when bundling this library #44

AviVahl opened this issue Aug 9, 2022 · 2 comments · Fixed by #46
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
September 2022

Comments

@AviVahl
Copy link
Contributor

AviVahl commented Aug 9, 2022

v5.1.0 had a regression when bundling using webpack:

 WARNING in ./node_modules/vscode-nls/lib/browser/main.js 26:14-44
  Module not found: Error: Can't resolve 'vscode-nls-web-data' in '/<project-path>/node_modules/vscode-nls/lib/browser'

regressed by #42
@TylerLeonhardt TylerLeonhardt added the bug Issue identified by VS Code Team member as probable bug label Aug 20, 2022
@TylerLeonhardt TylerLeonhardt added this to the August 2022 milestone Aug 20, 2022
@TylerLeonhardt TylerLeonhardt mentioned this issue Aug 29, 2022
Merged
@TylerLeonhardt
Copy link
Member

Just published 5.2.0 that has removed this feature.

@AviVahl
Copy link
Contributor Author

AviVahl commented Aug 30, 2022

Thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
September 2022
2 participants
@TylerLeonhardt @AviVahl