Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

set supportsLoadedSourcesRequest capability if DA implements the request #199

Closed
weinand opened this issue Jul 25, 2018 · 10 comments
Closed
Assignees
Labels
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 25, 2018

The new built-in loaded scripts explorer (which will appear in August) honors the supportsLoadedSourcesRequest capability and only shows the "Loaded Scripts" view if the value is true.

Please add this to the initializeRequestmethod:

	// This debug adapter supports loaded sources request
	response.body.supportsLoadedSourcesRequest = true;

This applies to the debug types: node2, extensionHost, and chrome.

I suggest to include this fix already in July because I will enable the loaded scripts explorer in Insiders as soon as the July release is out of the door.

For details please see microsoft/vscode#37767

@weinand weinand added the bug label Jul 25, 2018
@weinand weinand added this to the July 2018 milestone Jul 25, 2018
@weinand
Copy link
Contributor Author

weinand commented Aug 10, 2018

@roblourens I see this change in 1.26.8 but no longer in master.
Was there a problem with it?

@roblourens
Copy link
Member

It's also in master, where are you looking?

@weinand
Copy link
Contributor Author

weinand commented Aug 10, 2018

The capability is missing in the current Insiders and this commit removes it: a131f45
probably because it it now provided by vscode-chrome-debug-core.

It is not important for 1.26, but I was just wondering why the now built-in loadedscripts view no longer shows up...

@roblourens
Copy link
Member

This commit from a few days ago put it back: https://github.com/Microsoft/vscode-node-debug2/blob/master/src/nodeDebugAdapter.ts#L78

@weinand
Copy link
Contributor Author

weinand commented Aug 10, 2018

Sorry, but I do not see the supportsLoadedSourcesRequest in https://github.com/Microsoft/vscode-node-debug2/blob/master/src/nodeDebugAdapter.ts#L78:

2018-08-10_17-16-36

@roblourens
Copy link
Member

Sorry I was reading something completely different

@roblourens
Copy link
Member

Yes it is provided by -core now

@weinand
Copy link
Contributor Author

weinand commented Aug 10, 2018

...and the 1.26 version still uses an older core which doesn't have the capability.

@roblourens
Copy link
Member

I'll publish that for master now

@roblourens
Copy link
Member

microsoft/vscode@271a56a

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants