Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No comments in the editor when visiting file changes from commits #141

Closed
rebornix opened this issue Aug 8, 2018 · 4 comments
Closed

No comments in the editor when visiting file changes from commits #141

rebornix opened this issue Aug 8, 2018 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rebornix
Copy link
Member

rebornix commented Aug 8, 2018

  • VSCode version: 1aab8e140e17f30a60b95df32264a39eb155765d
  • Extension version: 0.0.7

Reproduce steps:

  • Checkout Pull Request from the tree view Hook up webflow auth during credential checks #94
  • Expand Commits node from Changes In Pull Request section
  • Expand Commit "Tweak the authentication user messages"
  • One file change src/github/credentials is shown and it has a comment icon
  • Click the file change, a diff editor is opened. No comment is shown in the editor
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 8, 2018
@rebornix
Copy link
Member Author

rebornix commented Aug 8, 2018

A DocumentCommentsProvider should be registered when visiting commits which have comments.

@rebornix
Copy link
Member Author

rebornix commented Aug 8, 2018

As there is no comments, we don't see commenting range decorations as well.

This was referenced Nov 19, 2021
Closed
Closed
@alexr00 alexr00 self-assigned this Jan 18, 2022
@alexr00 alexr00 modified the milestone: January 2022 Jan 18, 2022
@alexr00 alexr00 removed their assignment Jan 18, 2022
@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

Viewing comments works, but adding them still does not.

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

Adding comments is a duplicate of the more popular #2793

@alexr00 alexr00 closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebornix @RMacfarlane @alexr00