Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set reviewed on file view #3514

Open
brucejo75 opened this issue May 3, 2022 · 5 comments
Open

Automatically set reviewed on file view #3514

brucejo75 opened this issue May 3, 2022 · 5 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@brucejo75
Copy link

Related to scenario described here: #3513

I am in the process of reviewing a change to over 200 files. (yes, I know...)

I run VSCode with "workbench.editor.enablePreview": false (yes, I know.. I am a tab binger)

A "nice to have" would be an option to automatically mark as viewed when I open the file. Maybe githubpullrequest.markAsViewedOnFileOpen, for this large checkin review a lot of workflow friction would be eliminated.

Thanks!

@alexr00 alexr00 added the feature-request Request for new features or functionality label May 5, 2022
@alexr00 alexr00 added this to the On Deck milestone May 5, 2022
@joshuaobrien
Copy link
Contributor

Hey @alexr00, is it alright if I implement this feature?

@alexr00
Copy link
Member

alexr00 commented Feb 21, 2023

@joshuaobrien yes, I would accept a PR for this feature.

@umakantv
Copy link
Contributor

Hi @alexr00,
Seems like it's still open, I would like to take this up.

@joshuaobrien
Copy link
Contributor

joshuaobrien commented Jan 25, 2024

I've got a branch implementing some of this @umakantv, but I've been too busy to prioritise work on it. Let me know if it'd be helpful and I can upload it to my fork for you to take over

@umakantv
Copy link
Contributor

@joshuaobrien sure, let me know which branch, I would checkout and go through your changes, might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants