Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does clicking some files open on a comment and some not? #49

Closed
Tyriar opened this issue Jun 27, 2018 · 2 comments
Closed

Why does clicking some files open on a comment and some not? #49

Tyriar opened this issue Jun 27, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2018

PR: xtermjs/xterm.js#1460

Clicking the top file will open the file at the top, clicking the bottom one will open at the first comment.

image

I'm guessing it's since the second one has a comment but this feels weird. I read the comment earlier so I don't want to skip a bunch of lines in the diff every time I look at the file again.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2018
@rebornix
Copy link
Member

Diff editor will try to scroll to the first diff hunk, when there are comments in the first diff hunk, you have the feeling that it scrolls to the comments ;)

We are going to introduce a command for comment navigation, which allows us to navigate to the first comment in the editor.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2018

you have the feeling that it scrolls to the comments

This wasn't the case though, it was very inconsistent whether it would scroll to the comments or not. I later opened another one which had replies to me and it didn't scroll.

@rebornix rebornix self-assigned this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug comments
Projects
None yet
Development

No branches or pull requests

3 participants