Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Values: be smart about avoiding unnecessary repetition #413

Open
gjsjohnmurray opened this issue Jul 29, 2024 · 4 comments
Open

Inline Values: be smart about avoiding unnecessary repetition #413

gjsjohnmurray opened this issue Jul 29, 2024 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality needs community feedback

Comments

@gjsjohnmurray
Copy link

From the 1.92 release notes screenshot, it'd be neat if the InlineValuesProvider could become smart enough not to display the struck-through stuff:

image

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 29, 2024
@hidaris
Copy link

hidaris commented Jul 30, 2024

I personally think this is challenging. How do you decide how much information is smart to display? The VSCode team might need to define different display contexts here, which would require a lot of research and product design.

@paulacamargo25 paulacamargo25 added feature-request Request for new features or functionality and removed triage-needed Needs assignment to the proper sub-team labels Aug 1, 2024
@paulacamargo25
Copy link
Contributor

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@GentilsTo
Copy link

I jump on the issue to share some feedback too. Cool idea, but indeed might need some tweaking for not being "too much".

First, I think considering the docstring is a false positive (below in red the relevant inline, in blue the "too much")
image

Second, It get confused with the python f-string format:
image

@gjsjohnmurray
Copy link
Author

@GentilsTo please :+1 my original post to help it towards the 7 upvotes it'll need if it's to progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs community feedback
Projects
None yet
Development

No branches or pull requests

5 participants