Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debugger data viewer experiment flag #15529

Closed
joyceerhl opened this issue Mar 2, 2021 · 0 comments · Fixed by #15540
Closed

Remove debugger data viewer experiment flag #15529

joyceerhl opened this issue Mar 2, 2021 · 0 comments · Fixed by #15540
Assignees
@joyceerhl
Labels
area-data science feature-request Request for new features or functionality important Issue identified as high-priority

Comments

@joyceerhl
Copy link

/cc @luabud

If a customer is opted out of experiments they won't see the 'View Value in Data Viewer' context menu option, and they need to explicitly opt into the experiment:

"python.experiments.optInto": ["debuggerDataViewer"],

E.g. #15527 #15393 I believe we've decided to ship this integration so we should remove the flag.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 2, 2021
@joyceerhl joyceerhl added area-data science feature-request Request for new features or functionality and removed triage-needed Needs assignment to the proper sub-team labels Mar 2, 2021
@joyceerhl joyceerhl self-assigned this Mar 2, 2021
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 2, 2021
@luabud luabud added the needs PR label Mar 2, 2021
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 2, 2021
@luabud luabud added triage-needed Needs assignment to the proper sub-team important Issue identified as high-priority and removed triage-needed Needs assignment to the proper sub-team labels Mar 2, 2021
This was referenced Mar 3, 2021
Merged
Merged
@joyceerhl joyceerhl linked a pull request Mar 3, 2021 that will close this issue
Ship debugger data viewer integration #15540
Merged
@ghost ghost removed the needs PR label Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
area-data science feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ship debugger data viewer integration
2 participants
@joyceerhl @luabud