Signature provider for Jedi can fail with Unterminated group while building regex

[gramster]

2021.4.765268190
plaforms {'win32', 'darwin', 'linux'}

        SyntaxError: Invalid regular expression: /\s*:<REDACTED: user-file-path>*(a1:\s*([^\n, ]+)/: Unterminated group
                at new RegExp (<anonymous>)
                at /out/client/extension.js:59:3685
                at Array.forEach (<anonymous>)
                at /out/client/extension.js:59:3617
                at /out/client/extension.js:59:3848
                at Array.map (<anonymous>)
                at /out/client/extension.js:59:3495
                at Array.forEach (<anonymous>)
                at Function.parseData (/out/client/extension.js:59:3056)
                at /out/client/extension.js:59:4340
                at runMicrotasks (<anonymous>)
                at processTicksAndRejections (<REDACTED: user-file-path>:97:5)

[karthiknadig]

This is in old Jedi:

vscode-python/src/client/providers/signatureProvider.ts

Lines 19 to 23 in c1a8d94

	const DOCSTRING_PARAM_PATTERNS = [
	'\\s*:type\\s*PARAMNAME:\\s*([^\\n, ]+)', // Sphinx
	'\\s*:param\\s*(\\w?)\\s*PARAMNAME:[^\\n]+', // Sphinx param with type
	'\\s*@type\\s*PARAMNAME:\\s*([^\\n, ]+)', // Epydoc
	];

There is potential for this line to introduce errors in the regex:

vscode-python/src/client/providers/signatureProvider.ts

Line 40 in c1a8d94

pattern = pattern.replace('PARAMNAME', paramName);

We should catch the parsing error and just ignore it. This occurs while trying to extract parameter info, and if this fails it won't matter much. The text from the docs should still be visible to the user.

[kimadeline]

We use Jedi behind LSP now, we don't do any parsing anymore (#11995, #17225). Closing as stale.