Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show more clearly when a syntax error occurs #21123

Closed
rzhao271 opened this issue Apr 25, 2023 · 4 comments
Closed

Feature request: Show more clearly when a syntax error occurs #21123

rzhao271 opened this issue Apr 25, 2023 · 4 comments
Assignees

Comments

@rzhao271
Copy link

Testing #21091

A syntax error in a test causes "Test result not found" messages to show up when running that test. All tests in the test run also become red circles with dots.

Actual behaviour:
The user has to view the logs to see that a syntax error occurred.

Expected behaviour:
The test preview reports that a syntax error occurred, or elaborates on what "Test result not found" means, especially if a user is new to using pytest.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 25, 2023
@eleanorjboyd
Copy link
Member

To confirm the behavior you were seeing looks similar to this right?
Screenshot 2023-04-26 at 8 47 38 AM

@eleanorjboyd eleanorjboyd added the info-needed Issue requires more information from poster label Apr 26, 2023
@rzhao271
Copy link
Author

Yep

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Apr 26, 2023
@eleanorjboyd
Copy link
Member

sweet thanks! This is currently not a regression with the new testing rewrite since this is how the testing experience is now in vscode but is still something we would like to fix.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Apr 26, 2023
@eleanorjboyd eleanorjboyd added area-testing and removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Apr 28, 2023
@eleanorjboyd
Copy link
Member

No longer seeing this as an error occurs and the test can't be run so the red squiggly shows as indication. Behavior is now looking normal, thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants