Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Dev Container for development of extension #21387

Closed
anthonykim1 opened this issue Jun 8, 2023 · 2 comments
Closed

Creating Dev Container for development of extension #21387

anthonykim1 opened this issue Jun 8, 2023 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@anthonykim1
Copy link

anthonykim1 commented Jun 8, 2023

Creating Dev Container support for development of VSCode-Python extension on Codespaces, in which consists of:

  • Creating Dockerfile with multiple supported versions of Python, Node.js installed
  • Creating devcontainer.json that will point to the Docker file and relate to customization of necessary VSCode extension(s) customization
  • Script(s) and prebuilds related materials

Note the base image in the Dockerfile will be the latest version of Fedora Linux instead of mcr.microsoft.com/devcontainers/python:3.7 (Debian) referenced in #20960.

After completion should be able to close: #20942 and #20960


Testing: #21435

Steps:

  1. Open VS Code Python Repo via Codespaces from: https://github.com/microsoft/vscode-python
  2. Check to see .venv appear as one of the directories on the file explorer.
  3. Open a new instance of terminal, make sure it is the terminal with virtual environment activated (.venv)
  4. run "npm run test:functional"
  5. run "npm run test:unittests"
  6. run "npm run test"

Expected output:

  • Virtual environment is activated successfully after creating new instance of terminal as:
Screenshot 2023-06-26 at 4 23 38 PM
  • Typing "python" on virtual environment activated terminal gives access to "Python 3.7.16"

  • Typing "node" on virtual environment activated terminal gives access to "Node.js v16.17.1."

  • Expected output for step 4: One test failing ("pyenvs common utils - finding Python executables
    mixed
    "before all" hook in "mixed":....)

Screenshot 2023-06-26 at 4 19 25 PM
  • Expected output for step 5: Five tests failing (One from Interpreter Path Service and four tests from Activated Env Launch)
Screenshot 2023-06-26 at 4 20 47 PM
  • Expected output for step 6: Failing with ("error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory
    Exit code: 127
    End Standard tests (with errors) Failed")
Screenshot 2023-06-26 at 4 22 29 PM
@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Jun 8, 2023
@anthonykim1 anthonykim1 added this to the June 2023 milestone Jun 8, 2023
@anthonykim1 anthonykim1 self-assigned this Jun 8, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 8, 2023
@anthonykim1 anthonykim1 self-assigned this Jun 8, 2023
@anthonykim1 anthonykim1 changed the title Creating Dev Container support for extension support Creating Dev Container for development of extension Jun 8, 2023
@anthonykim1 anthonykim1 added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Jun 8, 2023
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Jun 26, 2023
@dbaeumer dbaeumer added the verified Verification succeeded label Jun 28, 2023
@dbaeumer
Copy link
Member

Actually the expected output looks different for me:

  • first the steps should mention that you need to run npm run compile
  • after step 4 I get:
  Python envs locator - WindowsPathEnvVarLocator
    iterEnvs()
     no executables found
     no executables match
     some executables match


  120 passing (21s)
  21 pending

@anthonykim1 please decide whether this is still OK or not.

@dbaeumer dbaeumer added verification-needed Verification of issue is requested verified Verification succeeded and removed verification-needed Verification of issue is requested verified Verification succeeded labels Jun 28, 2023
@anthonykim1
Copy link
Author

@dbaeumer
Thank you for testing!

It seems like virtual environment wasn't activated automatically (I'm assuming because of the killed terminal process). I was able to get the same result without the virtual environment and I believe this is issue with test itself since the base image is linux not windows..

However, manually activating .venv by typing "source /workspaces/vscode-python/.venv/bin/activate" should yield the same result as the pictures.

I'll look more into the issue. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
@eleanorjboyd eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants